Closed
Conversation
This was referenced Mar 24, 2019
Contributor
|
Closing this as superseded by #14906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the error handling from just printing errors directly to collecting them and returning them to the caller. The main motivation is to be able to make as much of the lexer pure, to remove any global state to make the compiler more useable as a library.
This is a draft PR. The commits are quite messy. Some things can be extracted into separate PRs. Some things will be moved to other modules. But the end result is kind of what I want it to look like. To reduce the number of changes the parser contains a few wrapper functions which calls the corresponding functions in the lexer and immediately prints any errors returned from the lexer. Ideally, in the future, the parser would use the same technique to push the errors further up the call stack.